-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: reduce tsconfig complexity #2102
Conversation
Waiting on #2099 to be merged |
It's literally the default argument. |
This explains why I did not found it 🤦 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2102 +/- ##
========================================
Coverage 99.59% 99.60%
========================================
Files 2643 2607 -36
Lines 245862 244977 -885
Branches 1151 1153 +2
========================================
- Hits 244877 244001 -876
+ Misses 958 949 -9
Partials 27 27 |
03de7b2
to
daae0d6
Compare
For the title: How about |
467ccc3
to
69d14a6
Compare
69d14a6
to
e2abe30
Compare
This PR should be merged before starting: |
a131eaf
to
4c09fd4
Compare
12fa514
to
d28e7dd
Compare
d28e7dd
to
5b3d955
Compare
This PR turns around the tsconfig files. Previously we had one tsconfig.base file, from which the others extends (but not the normal tsconfig.json).
Now we have one tsconfig.json which serves as the root/base config for all others!This tsconfig.json now only configures the minimum amount of base for all the other configs.Then we have three specific configs:build-types defines what is required to generate the files from src to dist/typeswe need to have this because it declares the "include: [src]" which is needed to tell tsc it only takes files from this folder.
I looked already if there is a CLI flag for --include, but sadly no.
then we have two (right now mostly identically) configs for scripts and tests.they differ in their "include"
We could discuss if we want to merge them into one file and just use one CI step to check tests and scripts folder, or we could just move the configs into there specific folders
The later option would result in VSCode would read them and process the configs for the folders
eslint now takes the tsconfig.json instead of its own lint.config
this results in that we now see even more lint errors that were previously hidden (see https://github.com/faker-js/faker/actions/runs/4822808872/jobs/8590495983?pr=2102)
Edit:
we now have one tsconfig.json which serves for all files and then one specific for the build process