Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing faker.location.state data in some locales #1977

Closed
matthewmayer opened this issue Mar 25, 2023 · 2 comments
Closed

Missing faker.location.state data in some locales #1977

matthewmayer opened this issue Mar 25, 2023 · 2 comments
Assignees
@matthewmayer
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@matthewmayer
Copy link
Contributor

matthewmayer commented Mar 25, 2023 •
edited
Loading

Various locales are missing states (or equivalent 1st level administrative regions like provinces) so fall back to en states.

I have already prepared data for some of these locales, but do you want this as

  • a) 1 big PR
  • b) 12 small PRs, one per language
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Mar 25, 2023
@matthewmayer matthewmayer self-assigned this Mar 25, 2023
@matthewmayer matthewmayer moved this to Todo in Faker Roadmap Mar 25, 2023
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Mar 25, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Mar 28, 2023

IMO having one PR per locale group/language (en_*) would be best.
That way we can easily forward it to people knowledgeable about that language.

@matthewmayer matthewmayer mentioned this issue Mar 28, 2023
Merged
@matthewmayer matthewmayer removed the s: needs decision Needs team/maintainer decision label Mar 28, 2023
This was referenced Mar 29, 2023
Merged
Merged
This was referenced May 5, 2023
Closed
Merged
@matthewmayer matthewmayer mentioned this issue May 9, 2023
Merged
@ejcheng ejcheng mentioned this issue Jul 1, 2023
Merged
This was referenced Jul 20, 2023
Merged
Merged
Merged
matthewmayer added a commit to matthewmayer/faker that referenced this issue Jul 21, 2023
@matthewmayer
feat(location): add states for mk
d4b800f 
the 80 municipalities of North Macedonia

https://mk.wikipedia.org/wiki/%D0%9E%D0%BF%D1%88%D1%82%D0%B8%D0%BD%D0%B8_%D0%B2%D0%BE_%D0%9C%D0%B0%D0%BA%D0%B5%D0%B4%D0%BE%D0%BD%D0%B8%D1%98%D0%B0

https://en.wikipedia.org/wiki/Municipalities_of_North_Macedonia

part of faker-js#1977
@matthewmayer matthewmayer mentioned this issue Aug 13, 2024
Closed
10 tasks
@matthewmayer
Copy link
Contributor Author

going to close this. individual issues/PRs can be created for any remaining states with no data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewmayer matthewmayer

Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Todo
Milestone
vAnytime
Development

No branches or pull requests
2 participants
@matthewmayer @ST-DDT