Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate regexpStyleStringParse #1985

Closed
matthewmayer opened this issue Mar 29, 2023 · 3 comments · Fixed by #2290
Closed

deprecate regexpStyleStringParse #1985

matthewmayer opened this issue Mar 29, 2023 · 3 comments · Fixed by #2290
Assignees
@ejcheng
Labels
c: chore PR that doesn't affect the runtime behavior deprecation A deprecation was made in the PR good first issue Good for newcomers m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@matthewmayer
Copy link
Contributor

Team decision

  • For now we don't change the existing method
  • Instead we will add a new method string.fromRegExp(string | RegExp): string
  • We will create a separate issue regarding deprecation of the old method

Originally posted by @ST-DDT in #1569 (comment)
@matthewmayer matthewmayer added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent deprecation A deprecation was made in the PR m: string Something is referring to the string module labels Mar 29, 2023
@matthewmayer matthewmayer moved this to Todo in Faker Roadmap Mar 29, 2023
@matthewmayer matthewmayer mentioned this issue Mar 29, 2023
Merged
@xDivisionByZerox
Copy link
Member

@matthewmayer What exactly is tracked by this issue? Can it be closed? For the actual depreciation, #1994 has been created.

@matthewmayer
Copy link
Contributor Author

#1994 seems to be about deprecating faker.helpers.replaceSymbolWithNumber
this issue would be for deprecating faker.helpers.regexpStyleStringParse

@xDivisionByZerox
Copy link
Member

Yes, you are correct. Excuse me, I was viewing those issues on my phone and got confused.

In that case, I'll add an good first issue label here as well.

@xDivisionByZerox xDivisionByZerox added the good first issue Good for newcomers label Jul 14, 2023
@ejcheng ejcheng mentioned this issue Aug 5, 2023
Merged
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ejcheng ejcheng

Labels
c: chore PR that doesn't affect the runtime behavior deprecation A deprecation was made in the PR good first issue Good for newcomers m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Todo
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

chore(helpers): deprecate regexpStyleStringParse faker-js/faker
4 participants
@matthewmayer @ST-DDT @ejcheng @xDivisionByZerox