-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add overview guides to specific modules #1929
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1929 +/- ##
==========================================
+ Coverage 99.61% 99.63% +0.01%
==========================================
Files 2460 2450 -10
Lines 239942 239952 +10
Branches 1274 1276 +2
==========================================
+ Hits 239024 239068 +44
+ Misses 895 862 -33
+ Partials 23 22 -1
|
I think the links wont work locally in our IDEs. |
What would a fully qualified link look like in markdown? |
It starts with https. Sorry if I messed up the terms. |
Which hostname though? |
I thought about using next until we release v8 and adjust the main docs version. In the docs build we should adjust it to absolute links (without hostname) though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a test to our signature tests
the existing signature snapshot tests only seem to be for method signatures, not sure how to add for module comments? |
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
fix #1928
examples: