-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): locale proxy #2099
fix(types): locale proxy #2099
Conversation
I'm not sure whether this is the correct solution. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2099 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 2567 2567
Lines 243368 243371 +3
Branches 1253 1247 -6
==========================================
- Hits 242394 242380 -14
- Misses 947 964 +17
Partials 27 27
|
I'm pretty sure that is because the test files are not concluded in the If you then activate the |
I checked if we could use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to start adding TS compile tests to the project. Just an idea.
No, we just need to start using we dont need tests, we need more safe checked TS itself |
The main sources don't show the error, but the test code does:
(e.g. date.spec.ts)