feat(locale): add states to vi locale and fix city name #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asharnadeem
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2128 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2638 2639 +1
Lines 244685 244720 +35
Branches 1082 1084 +2
=======================================
+ Hits 243703 243743 +40
+ Misses 955 950 -5
Partials 27 27
|
matthewmayer
requested changes
May 5, 2023
ST-DDT
added
p: 1-normal
matthewmayer
approved these changes
Jul 21, 2023
import-brain
approved these changes
Jul 22, 2023
ST-DDT
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses concerns in #1977. Adds
statesupport for thevilocale, and as part of this PR, also fixescity_namewhere the previous list included both cities and states. This PR introduces more realistic location data overall for thevilocale