Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Fix failing test finance in win32 system #223

Closed
Shinigami92 opened this issue Jan 18, 2022 · 1 comment
Closed

Test: Fix failing test finance in win32 system #223

Shinigami92 opened this issue Jan 18, 2022 · 1 comment
Labels
c: bug Something isn't working c: test

Comments

@Shinigami92
Copy link
Member

Describe the bug

The below test is failing in GitHub Workflow's CI and needs to be fixed.

This was discovered in #179

Reproduction

Remove the conditional wrapper and see CI failing

Additional Info

faker/test/finance.unit.js

Lines 283 to 302 in 80e8b3d

// TODO @Shinigami92 2022-01-18: See https://github.com/faker-js/faker/pull/179
if (require('os').platform() !== 'win32') {
it('should return the number formatted on the current locale', function () {
const number = 6000,
decimalPlaces = 2;
const expected = number.toLocaleString(undefined, {
minimumFractionDigits: decimalPlaces,
});
const amount = faker.finance.amount(
number,
number,
decimalPlaces,
undefined,
true
);
assert.strictEqual(amount, expected);
});
}

@Shinigami92 Shinigami92 added s: pending triage Pending Triage c: bug Something isn't working labels Jan 18, 2022
@github-actions github-actions bot removed the s: pending triage Pending Triage label Jan 18, 2022
@Shinigami92 Shinigami92 linked a pull request Jan 18, 2022 that will close this issue
@Shinigami92 Shinigami92 moved this to Awaiting Review in Faker Roadmap Jan 18, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2022

Is this obsolete since #235 is merged?

Repository owner moved this from Awaiting Review to Done in Faker Roadmap Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: test
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants