Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #158

Merged
merged 6 commits into from
Jan 19, 2022
Merged

chore: add CODEOWNERS #158

merged 6 commits into from
Jan 19, 2022

Conversation

damienwebdev
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jan 15, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 2b915eb

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e80feedeb60a00082e6107

😎 Browse the preview: https://deploy-preview-158--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 self-requested a review January 15, 2022 18:49
@Shinigami92 Shinigami92 added the p: 3-urgent Fix and release ASAP label Jan 15, 2022
Shinigami92
Shinigami92 previously approved these changes Jan 15, 2022
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
import-brain
import-brain previously approved these changes Jan 15, 2022
.github/CODEOWNERS Outdated Show resolved Hide resolved
@prisis prisis added this to the v6.0.0 milestone Jan 16, 2022
@Shinigami92 Shinigami92 marked this pull request as draft January 16, 2022 16:29
clarkerican
clarkerican previously approved these changes Jan 17, 2022
.github/CODEOWNERS Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 dismissed stale reviews from clarkerican and import-brain via 5e43e11 January 19, 2022 13:16
.github/CODEOWNERS Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as ready for review January 19, 2022 13:19
@Shinigami92 Shinigami92 requested a review from a team January 19, 2022 13:19
@Shinigami92
Copy link
Member

Oh no 😱 Are the tests really flaky? 😖
I will ignore that then for now, but then we have a real issue and should handle that somewhat somehow together in #223

image


I re-run the test and now it is green 👀 🤷

@Shinigami92 Shinigami92 merged commit ae59920 into main Jan 19, 2022
@Shinigami92 Shinigami92 deleted the update_codeowners branch January 19, 2022 13:30
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: 3-urgent Fix and release ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(codeowner): add codeowners file for clear reviews
5 participants