-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(location): update en county list #2238
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2238 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 2760 2760
Lines 251164 251266 +102
Branches 1081 1083 +2
==========================================
+ Hits 250176 250274 +98
- Misses 961 965 +4
Partials 27 27
|
Shouldn't we mix other states counties in as well otherwise en == en_US. |
We don't do that for state() |
There seems to be merge conflicts. Could you please fix them? |
Team decision We will use both the "British" and US county names for |
Done. Note this is a good example of why you don't always want to sort definitions alphabetically re #2265 |
re #2207 #1944
Updates the en county list to be a lomger list of US-esque county names instead of a
truncated list of GB county names.