Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(location): update en county list #2238

Merged
merged 5 commits into from
Sep 1, 2023
Merged

feat(location): update en county list #2238

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b41547a
locale(location): update en county list to match en_US
matthewmayer Jul 5, 2023
e76ca76
Merge branch 'next' into en-county
matthewmayer Aug 5, 2023
7bad990
merge of en_GB and en_US
matthewmayer Aug 18, 2023
383f5f2
Merge branch 'next' into en-county
ST-DDT Aug 20, 2023
3a0fc17
Merge branch 'next' into en-county
ST-DDT Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions src/locales/en/location/county.ts
View file
Open in desktop
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,8 +1,110 @@
// This is a combination of sample en_US and en_GB county names
// https://github.com/faker-js/faker/pull/2238#issuecomment-1682737025
export default [
'Adams County',
'Calhoun County',
'Carroll County',
'Clark County',
'Clay County',
'Crawford County',
'Douglas County',
'Fayette County',
'Franklin County',
'Grant County',
'Greene County',
'Hamilton County',
'Hancock County',
'Henry County',
'Jackson County',
'Jefferson County',
'Johnson County',
'Lake County',
'Lawrence County',
'Lee County',
'Lincoln County',
'Logan County',
'Madison County',
'Marion County',
'Marshall County',
'Monroe County',
'Montgomery County',
'Morgan County',
'Perry County',
'Pike County',
'Polk County',
'Scott County',
'Union County',
'Warren County',
'Washington County',
'Wayne County',
'Avon',
'Bedfordshire',
'Berkshire',
'Borders',
'Buckinghamshire',
'Cambridgeshire',
'Central',
'Cheshire',
'Cleveland',
'Clwyd',
'Cornwall',
'County Antrim',
'County Armagh',
'County Down',
'County Fermanagh',
'County Londonderry',
'County Tyrone',
'Cumbria',
'Derbyshire',
'Devon',
'Dorset',
'Dumfries and Galloway',
'Durham',
'Dyfed',
'East Sussex',
'Essex',
'Fife',
'Gloucestershire',
'Grampian',
'Greater Manchester',
'Gwent',
'Gwynedd County',
'Hampshire',
'Herefordshire',
'Hertfordshire',
'Highlands and Islands',
'Humberside',
'Isle of Wight',
'Kent',
'Lancashire',
'Leicestershire',
'Lincolnshire',
'Lothian',
'Merseyside',
'Mid Glamorgan',
'Norfolk',
'North Yorkshire',
'Northamptonshire',
'Northumberland',
'Nottinghamshire',
'Oxfordshire',
'Powys',
'Rutland',
'Shropshire',
'Somerset',
'South Glamorgan',
'South Yorkshire',
'Staffordshire',
'Strathclyde',
'Suffolk',
'Surrey',
'Tayside',
'Tyne and Wear',
'Warwickshire',
'West Glamorgan',
'West Midlands',
'West Sussex',
'West Yorkshire',
'Wiltshire',
'Worcestershire',
];
6 changes: 3 additions & 3 deletions test/modules/__snapshots__/location.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[`location > 42 > countryCode > with alphaCode option 1`] = `"GUY"`;

exports[`location > 42 > countryCode > with string 1`] = `"GY"`;

exports[`location > 42 > county 1`] = `"Berkshire"`;
exports[`location > 42 > county 1`] = `"Borders"`;

exports[`location > 42 > direction > noArgs 1`] = `"South"`;

Expand Down Expand Up @@ -172,7 +172,7 @@ exports[`location > 1211 > countryCode > with alphaCode option 1`] = `"UMI"`;

exports[`location > 1211 > countryCode > with string 1`] = `"UM"`;

exports[`location > 1211 > county 1`] = `"Cambridgeshire"`;
exports[`location > 1211 > county 1`] = `"Tyne and Wear"`;

exports[`location > 1211 > direction > noArgs 1`] = `"Southwest"`;

Expand Down Expand Up @@ -324,7 +324,7 @@ exports[`location > 1337 > countryCode > with alphaCode option 1`] = `"ESH"`;

exports[`location > 1337 > countryCode > with string 1`] = `"EH"`;

exports[`location > 1337 > county 1`] = `"Bedfordshire"`;
exports[`location > 1337 > county 1`] = `"Morgan County"`;

exports[`location > 1337 > direction > noArgs 1`] = `"South"`;

Expand Down