Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unrelated entries from de_CH country codes #2304

Merged
merged 2 commits into from
Aug 18, 2023
Merged

fix: remove unrelated entries from de_CH country codes #2304

merged 2 commits into from
Aug 18, 2023

Conversation

import-brain
Copy link
Member

closes #1861

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Aug 10, 2023
@import-brain import-brain requested a review from a team August 10, 2023 05:54
@import-brain import-brain self-assigned this Aug 10, 2023
@import-brain import-brain requested a review from a team as a code owner August 10, 2023 05:54
@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #2304 (bab2efe) into next (b468d5f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2304      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2644     2644              
  Lines      245617   245613       -4     
  Branches     1083     1083              
==========================================
- Hits       244645   244639       -6     
- Misses        945      947       +2     
  Partials       27       27
Files Changed Coverage Δ
src/locales/de_CH/location/country_code.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team August 10, 2023 06:53
@ST-DDT ST-DDT added the m: location Something is referring to the location module label Aug 10, 2023
@import-brain import-brain mentioned this pull request Aug 10, 2023
Open
@ST-DDT ST-DDT merged commit aa1bb13 into next Aug 18, 2023
@ST-DDT ST-DDT deleted the remove_unrelated_deCH_country_codes branch August 18, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@matthewmayer matthewmayer matthewmayer approved these changes

Assignees

@import-brain import-brain

Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Remove unrelatistic elements from de_CH/location/country_code
4 participants
@import-brain @matthewmayer @ST-DDT @xDivisionByZerox