-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helpers)!: use const generics where possible #2685
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2685 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 2815 2815
Lines 250300 250304 +4
Branches 1085 1086 +1
=======================================
+ Hits 249238 249243 +5
+ Misses 1062 1061 -1
|
Should we add a https://vitest.dev/api/expect-typeof.html for this specific case? |
I haven't used that feature yet, and I do not know whether/how to proceed regarding testing of this type only feature. |
Would you consider this This is a user facing change, but it technically isn't anymore breaking than using the new node features after updating to them. |
Implements #2679
const
modifier on type parameters #2679This feature requires TS5+ and thus is a breaking change.