Broken accents with some generic first_name definitions in Italian locale

[matthewmayer]

faker/src/locales/it/person/first_name.ts

Line 397 in 56acea3

'Esa�',

There are 6 names in the it person.first_name.generic list that appear to have broken accents

• Esa�
• Giosu�
• Mos�
• Nicol�
• No�
• Salom�

corresponding to

Esaù
Giosuè
Mosè
Nicolò
Noè
Salomè

in the male/female lists

[ST-DDT]

Would you like to create a PR for this?

[matthewmayer]

Will do. i want to track down where this was introduced first.

[ST-DDT]

Looks like it was introduced in #169

• fix: ts support for locales #169

---

• Before:
  • https://github.com/faker-js/faker/blame/ae5992039da10fa3f5433f6bfc0e65bc351684fc/lib/locales/it/name/first_name.js#L396
  • 61d0296#diff-3bfd1decf8d704b83571293b5f5652114ea1234ce129a2b967b7067c7da84fd1L396
• After:
  • https://github.com/faker-js/faker/blame/92a2f178343f4413bd6d782a7957eda86aa1b7b8/src/locales/it/person/first_name.ts#L396
  • 61d0296#diff-d9b007b750fab6413d9cfb3662e6061be8bff4f738b0feb284a60ab5cf43fa00R396

Though I'm unsure how this happened, as it only affects this particular file.

• https://github.com/search?q=repo%3Afaker-js%2Ffaker%20%EF%BF%BD&type=code (� in 1 files)
• https://github.com/search?q=repo%3Afaker-js%2Ffaker%20%C3%B9&type=code (ù in 7 files)
• https://github.com/search?q=repo%3Afaker-js%2Ffaker%20%C3%A8&type=code (è in 54 files)
• https://github.com/search?q=repo%3Afaker-js%2Ffaker%20%C3%B2&type=code (ò in 7 files)

Might be a charset detection glitch during commit or when opening the file with an IDE.
IMO we don't have to dig to deeply into this.