Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): fix incorrect accents in it first_name #3281

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

matthewmayer
Copy link
Contributor

fix #3280

@matthewmayer matthewmayer requested a review from a team as a code owner November 25, 2024 14:22
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 058102f
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6744a204f094d300084ab04d
😎 Deploy Preview https://deploy-preview-3281.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer self-assigned this Nov 25, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 25, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 25, 2024
@ST-DDT ST-DDT requested review from a team November 25, 2024 14:45
@xDivisionByZerox xDivisionByZerox added c: bug Something isn't working s: accepted Accepted feature / Confirmed bug labels Nov 25, 2024
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (eef3702) to head (058102f).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3281      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      217156   217156              
  Branches      980      978       -2     
==========================================
- Hits       217093   217076      -17     
- Misses         63       80      +17     
Files with missing lines Coverage Δ
src/locales/it/person/first_name.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

---- 🚨 Try these New Features:

Merged via the queue into faker-js:next with commit e0fb23e Nov 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken accents with some generic first_name definitions in Italian locale
4 participants