Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded mime types #378

Closed
ST-DDT opened this issue Jan 30, 2022 · 5 comments · Fixed by #808
Closed

Update embedded mime types #378

ST-DDT opened this issue Jan 30, 2022 · 5 comments · Fixed by #808
Assignees
Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Jan 30, 2022

Clear and concise description of the problem

The mime types are potentially outdated.

Definitions from mime-db v1.21.0
For updates check: https://github.com/jshttp/mime-db/blob/master/db.json

Suggested solution

Update to the latest version (v1.51.0).

Alternative

No response

Additional context

No response

@ST-DDT ST-DDT added the c: feature Request for new feature label Jan 30, 2022
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Jan 30, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Jan 31, 2022
@prisis
Copy link
Member

prisis commented Feb 1, 2022

How about we add the mime-db as dependency?

@Shinigami92
Copy link
Member

How about we add the mime-db as dependency?

I would like to work with scoped dependencies, so I mean e.g. something like @faker-js/system
or
I would like to use optional peerDependencies for something like this

Currently because it's "easier" I tend to the second way 🤔

@franznoel
Copy link

franznoel commented Feb 19, 2022

Using the validator package also needs to be updated because it is not in sync with the current given list of mimeTypes:

https://github.com/jshttp/mime-db/blob/master/db.json

We might also need to apply mime-db inside the validator package. Not sure if it's there. 😅

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 19, 2022

Using the validator package also needs to be updated because it is not in sync with the current given list of mimeTypes:

Could you please explain why?
Which part is not in compliance with the current version?

We might also need to apply mime-db inside the validator package. Not sure if it's there. 😅

It's not.

https://github.com/validatorjs/validator.js/blob/master/src/lib/isMimeType.js

@franznoel
Copy link

Could you please explain why?
Which part is not in compliance with the current version?

Earlier, when I ran the unit test, it seems to be lacking some mimeTypes. However, showing me that link on the code for isMimeType does not seem to be applicable.

@ST-DDT ST-DDT linked a pull request Feb 21, 2022 that will close this issue
@Shinigami92 Shinigami92 moved this from Todo to In Progress in Faker Roadmap Feb 22, 2022
@Shinigami92 Shinigami92 linked a pull request Apr 8, 2022 that will close this issue
@Shinigami92 Shinigami92 moved this from In Progress to Awaiting Review in Faker Roadmap Apr 8, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Apr 8, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Apr 8, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
4 participants