-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update mimeType extensions from mime-db v1.52.0 #535
Conversation
Please also update the version number in the jsdocs. |
5ae6a98
to
b052aeb
Compare
How should I update the jsdocs version? Is there a contributing guide? |
Codecov Report
@@ Coverage Diff @@
## main #535 +/- ##
=========================================
Coverage 99.33% 99.34%
=========================================
Files 1923 1923
Lines 176857 178815 +1958
Branches 908 908
=========================================
+ Hits 175687 177645 +1958
Misses 1114 1114
Partials 56 56
|
I'm referring to this line: faker/src/locales/en/system/mimeTypes.ts Line 25 in 1058e17
Please update it to the exact tag-name (version) of the commit you used to import the db from. I assume it's https://github.com/jshttp/mime-db/releases/tag/v1.52.0 . |
b052aeb
to
700a299
Compare
700a299
to
1d48906
Compare
I would love to see this out in next version, how can I help with this? |
1d48906
to
f2c689f
Compare
@Shinigami92 IMO this is a |
f2c689f
to
35adc77
Compare
'mpeg', | ||
'wav', | ||
'png', | ||
'jpe', | ||
'jpeg', | ||
'gif', | ||
'mp4v', | ||
'mpeg', | ||
'htm', | ||
'm2a', | ||
'm3a', | ||
'mpe', | ||
'mp3', | ||
'mp4', | ||
'mpg', | ||
'mpga', | ||
'mp2a', | ||
'm2v', | ||
'shtml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you order this extList
and remove the duplicate mpeg
?
Then we have less conflicts in the future.
All |
We use And because its not dependency, I cant override it in yarn resolves. |
This PR needs to be rebased/updated. |
I have a different approach #808 |
Superseded by #808 . Thanks for your contribution. |
Description
Updated the
mimeTypes
list ofsystem
coming from mime-db v1.52.0Taken from this list: https://github.com/jshttp/mime-db/blob/v1.52.0/db.json