Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update mimeType extensions from mime-db v1.52.0 #535

Closed

Conversation

franznoel
Copy link

@franznoel franznoel commented Feb 21, 2022

Description

Updated the mimeTypes list of system coming from mime-db v1.52.0

Taken from this list: https://github.com/jshttp/mime-db/blob/v1.52.0/db.json

@franznoel franznoel requested a review from a team as a code owner February 21, 2022 21:29
test/system.spec.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented Feb 21, 2022

Please also update the version number in the jsdocs.

@franznoel franznoel force-pushed the #378-update-embedded-mimetypes branch 4 times, most recently from 5ae6a98 to b052aeb Compare February 21, 2022 22:11
@ST-DDT ST-DDT added this to the v6.2 - New small features milestone Feb 21, 2022
@ST-DDT ST-DDT linked an issue Feb 21, 2022 that may be closed by this pull request
@franznoel
Copy link
Author

franznoel commented Feb 21, 2022

Please also update the version number in the jsdocs.

How should I update the jsdocs version? Is there a contributing guide?

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #535 (35adc77) into main (e643835) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             main     #535     +/-   ##
=========================================
  Coverage   99.33%   99.34%             
=========================================
  Files        1923     1923             
  Lines      176857   178815   +1958     
  Branches      908      908             
=========================================
+ Hits       175687   177645   +1958     
  Misses       1114     1114             
  Partials       56       56             
Impacted Files Coverage Δ
src/locales/en/system/mimeTypes.ts 100.00% <ø> (ø)

@ST-DDT
Copy link
Member

ST-DDT commented Feb 21, 2022

update the version number

How should I update the jsdocs version?

I'm referring to this line:

Definitions from mime-db v1.21.0

Please update it to the exact tag-name (version) of the commit you used to import the db from.

I assume it's https://github.com/jshttp/mime-db/releases/tag/v1.52.0 .

@franznoel franznoel force-pushed the #378-update-embedded-mimetypes branch from b052aeb to 700a299 Compare February 21, 2022 23:04
ST-DDT
ST-DDT previously approved these changes Feb 21, 2022
@ST-DDT ST-DDT requested a review from a team February 21, 2022 23:18
src/locales/en/system/mimeTypes.ts Outdated Show resolved Hide resolved
test/system.spec.ts Show resolved Hide resolved
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent and removed c: test labels Feb 22, 2022
@franznoel franznoel force-pushed the #378-update-embedded-mimetypes branch from 700a299 to 1d48906 Compare February 22, 2022 16:51
@franznoel franznoel changed the title feat: Update mimeType extensions feat: Update mimeType extensions to mime-db v1.52.0 Feb 22, 2022
@franznoel franznoel changed the title feat: Update mimeType extensions to mime-db v1.52.0 feat: Update mimeType extensions from mime-db v1.52.0 Feb 22, 2022
ST-DDT
ST-DDT previously approved these changes Feb 22, 2022
@ST-DDT ST-DDT requested a review from a team February 22, 2022 18:04
@Shinigami92 Shinigami92 added the c: feature Request for new feature label Mar 15, 2022
@HonzaMac
Copy link
Contributor

I would love to see this out in next version, how can I help with this?

@ST-DDT ST-DDT force-pushed the #378-update-embedded-mimetypes branch from 1d48906 to f2c689f Compare March 23, 2022 11:50
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Mar 23, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Mar 23, 2022

@Shinigami92 IMO this is a c: locale and thus can be merged in v6.1.

ST-DDT
ST-DDT previously approved these changes Mar 23, 2022
@ST-DDT ST-DDT requested a review from a team March 23, 2022 11:57
@ST-DDT ST-DDT force-pushed the #378-update-embedded-mimetypes branch from f2c689f to 35adc77 Compare March 23, 2022 12:00
Comment on lines 102 to +120
'mpeg',
'wav',
'png',
'jpe',
'jpeg',
'gif',
'mp4v',
'mpeg',
'htm',
'm2a',
'm3a',
'mpe',
'mp3',
'mp4',
'mpg',
'mpga',
'mp2a',
'm2v',
'shtml',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you order this extList and remove the duplicate mpeg?
Then we have less conflicts in the future.

@Shinigami92 Shinigami92 added c: locale Permutes locale definitions and removed c: feature Request for new feature labels Mar 23, 2022
@Shinigami92
Copy link
Member

@Shinigami92 IMO this is a c: locale and thus can be merged in v6.1.

All c: locale are currently target for v6.2: https://github.com/faker-js/faker/pulls?q=is%3Aopen+is%3Apr+label%3A%22c%3A+locale%22
Why handle this PR differently?

@HonzaMac
Copy link
Contributor

HonzaMac commented Mar 23, 2022

We use mime-types for input validation (which use mimedb inside). Problem is that faker generates extensions i.e. mbp which was renamed later, but it fails our suites sometimes when Faker generate it. Faker have mimedb from 2016.

And because its not dependency, I cant override it in yarn resolves.

@Shinigami92 Shinigami92 added the s: needs decision Needs team/maintainer decision label Mar 23, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Apr 5, 2022

This PR needs to be rebased/updated.

@ST-DDT ST-DDT added needs rebase There is a merge conflict and removed s: needs decision Needs team/maintainer decision labels Apr 5, 2022
@prisis
Copy link
Member

prisis commented Apr 8, 2022

I have a different approach #808

@ST-DDT
Copy link
Member

ST-DDT commented Apr 8, 2022

Superseded by #808 . Thanks for your contribution.

@ST-DDT ST-DDT closed this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions needs rebase There is a merge conflict p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update embedded mime types
6 participants