Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve behavior of generate:locales #389

Closed
ST-DDT opened this issue Feb 1, 2022 · 3 comments
Closed

Improve behavior of generate:locales #389

ST-DDT opened this issue Feb 1, 2022 · 3 comments
Labels
c: feature Request for new feature p: 1-normal Nothing urgent
Milestone
v6 - Non-Breaking...

Comments

@ST-DDT
Copy link
Member

ST-DDT commented Feb 1, 2022

Can we create a ticket to add a workflow test for this? that is only running if something in the locales folder did change?

@prisis

Can we create a ticket to add a workflow test for this? that is only running if something in the locales folder did change?

Originally posted by @prisis in #252 (comment)
@ST-DDT ST-DDT added c: feature Request for new feature c: chore PR that doesn't affect the runtime behavior labels Feb 1, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 1, 2022

Are you referring to running the command in the workflow/ci pipeline and failing if it detects changes that weren't commited?

@prisis
Copy link
Member

prisis commented Feb 1, 2022

Are you referring to running the command in the workflow/ci pipeline and failing if it detects changes that weren't commited?

Yeah, so we will not forget it :)

@import-brain import-brain moved this to Todo in Faker Roadmap Feb 1, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent and removed c: chore PR that doesn't affect the runtime behavior labels Mar 23, 2022
@ST-DDT ST-DDT mentioned this issue Apr 8, 2022
Closed
@Shinigami92
Copy link
Member

Close in favor of #813

Repository owner moved this from Todo to Done in Faker Roadmap Apr 8, 2022
@ST-DDT ST-DDT removed this from Faker Roadmap Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: feature Request for new feature p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6 - Non-Breaking Changes
Development

No branches or pull requests
3 participants
@ST-DDT @prisis @Shinigami92