Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI steps to test execution of generate scripts #813

Closed
Shinigami92 opened this issue Apr 8, 2022 · 4 comments · Fixed by #1405
Closed

Add CI steps to test execution of generate scripts #813

Shinigami92 opened this issue Apr 8, 2022 · 4 comments · Fixed by #1405
Assignees
@sunadoi
Labels
c: infra Changes to our infrastructure or project setup good first issue Good for newcomers help wanted Extra attention is needed p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Milestone
v8.x

Comments

@Shinigami92
Copy link
Member

Clear and concise description of the problem

We need to add CI steps for the execution of some generate scripts, so we guarantee that these will not break

Suggested solution

Add steps

Alternative

No response

Additional context

No response
@Shinigami92 Shinigami92 added s: pending triage Pending Triage c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug and removed s: pending triage Pending Triage labels Apr 8, 2022
@Shinigami92 Shinigami92 moved this to Todo in Faker Roadmap Apr 8, 2022
@Shinigami92 Shinigami92 added this to the v6 - Non-Breaking Changes milestone Apr 8, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Apr 8, 2022

See also #389

@Shinigami92 Shinigami92 mentioned this issue Apr 8, 2022
Closed
@ST-DDT ST-DDT mentioned this issue May 3, 2022
Closed
@ST-DDT ST-DDT added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 8, 2022
@Shinigami92 Shinigami92 added c: infra Changes to our infrastructure or project setup and removed c: chore PR that doesn't affect the runtime behavior labels Sep 8, 2022
@xDivisionByZerox
Copy link
Member

Concept:

Add a job to the ci.yaml that runs the generate-locale and generate-locale scripts from our package.json.

@ST-DDT
Copy link
Member

ST-DDT commented Sep 8, 2022

And it should ensure that there are no changed files afterwards.

@sunadoi
Copy link
Contributor

sunadoi commented Oct 1, 2022

Could you assign to me?

@sunadoi sunadoi mentioned this issue Oct 2, 2022
Merged
@ST-DDT ST-DDT linked a pull request Oct 2, 2022 that will close this issue
infra: add CI step to detect generate script diffs #1405
Merged
@ST-DDT ST-DDT moved this from Todo to Awaiting Review in Faker Roadmap Oct 2, 2022
Repository owner moved this from Awaiting Review to Done in Faker Roadmap Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunadoi sunadoi

Labels
c: infra Changes to our infrastructure or project setup good first issue Good for newcomers help wanted Extra attention is needed p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging a pull request may close this issue.

infra: add CI step to detect generate script diffs sunadoi/faker
4 participants
@ST-DDT @Shinigami92 @sunadoi @xDivisionByZerox