-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
city does not return localized city name #983
Labels
c: locale
Permutes locale definitions
good first issue
Good for newcomers
has workaround
Workaround provided or linked
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Milestone
Comments
Currently faker/src/locales/en_CA/address/index.ts Lines 13 to 20 in bd4d3db
If you want Canadian city names you have to create a PR and provide us with a list of some. |
ST-DDT
added
good first issue
Good for newcomers
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
and removed
s: pending triage
Pending Triage
labels
May 22, 2022
Until we can add them/merge that PR you can set them yourself: |
wingleungchoi
pushed a commit
to wingleungchoi/faker
that referenced
this issue
May 24, 2022
Shinigami92
pushed a commit
that referenced
this issue
May 24, 2022
Repository owner
moved this from Todo
to Done
in Faker Roadmap
May 24, 2022
Minozzzi
pushed a commit
to Minozzzi/faker
that referenced
this issue
Jul 19, 2022
Co-authored-by: Wing Leung Choi <wchoi@and.digital>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
good first issue
Good for newcomers
has workaround
Workaround provided or linked
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Describe the bug
has set localized value to "en_CA" and i want city to return based on canada, to be more precise i would love to have city return based on province i have choosen.
Currently i am getting province from canada but city is returning USA cities.
Reproduction
import { faker } from "@faker-js/faker";
faker.setLocale("en_CA");
const province = faker.address.state(); //this gives canadian province
const city = faker.address.cityName(); //but this does not give canadian cities
console.log(province);
console.log(city);
Additional Info
No response
The text was updated successfully, but these errors were encountered: