Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add science module to readme #1039

Merged
merged 4 commits into from
Jun 8, 2022
Merged

docs: add science module to readme #1039

merged 4 commits into from
Jun 8, 2022

Conversation

ejcheng
Copy link
Member

@ejcheng ejcheng commented Jun 5, 2022

No description provided.

@ejcheng ejcheng added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jun 5, 2022
@ejcheng ejcheng added this to the v7 - Current Major milestone Jun 5, 2022
@ejcheng ejcheng requested a review from a team June 5, 2022 18:15
@ejcheng ejcheng self-assigned this Jun 5, 2022
@ejcheng ejcheng requested a review from a team June 5, 2022 18:15
@ejcheng ejcheng requested a review from a team as a code owner June 5, 2022 18:15
@codecov
Copy link

codecov bot commented Jun 5, 2022 •
edited
Loading

Codecov Report

Merging #1039 (eb5a21c) into main (38805db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1039   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files        2124     2124           
  Lines      228224   228224           
  Branches      989      989           
=======================================
  Hits       227456   227456           
  Misses        747      747           
  Partials       21       21

Shinigami92
Shinigami92 previously approved these changes Jun 6, 2022
View reviewed changes
@Shinigami92 Shinigami92 requested a review from a team June 6, 2022 10:12
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Jun 7, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jun 7, 2022

There seems to be merge conflicts. Could you please fix them?

@ejcheng ejcheng force-pushed the readme-science-module branch from 32e264d to eb5a21c Compare June 7, 2022 22:43
@ejcheng ejcheng removed the needs rebase There is a merge conflict label Jun 7, 2022
@ST-DDT ST-DDT requested review from Shinigami92 and a team June 7, 2022 23:18
@Shinigami92 Shinigami92 merged commit c5ac124 into main Jun 8, 2022
@Shinigami92 Shinigami92 deleted the readme-science-module branch June 11, 2022 14:41
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@ejcheng @Minozzzi
docs: add science module to readme (faker-js#1039)
b803807
@xDivisionByZerox xDivisionByZerox added the m: science Something is referring to the science module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@ejcheng ejcheng

Labels
c: docs Improvements or additions to documentation m: science Something is referring to the science module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
4 participants
@ejcheng @ST-DDT @Shinigami92 @xDivisionByZerox