chore(unsplash): deprecate unused const

[import-brain]

This is a todo on "source code todo list v2"

[codecov]

Codecov Report

Merging #1046 (e660c69) into main (f4d23eb) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2135     2135              
  Lines      229213   229217       +4     
  Branches      980      979       -1     
==========================================
+ Hits       228402   228405       +3     
- Misses        790      791       +1     
  Partials       21       21              

Impacted Files	Coverage Δ
src/modules/image/providers/unsplash.ts	95.32% <100.00%> (+0.11%)	⬆️
src/modules/finance/index.ts	99.31% <0.00%> (-0.69%)	⬇️
src/modules/internet/user-agent.ts	86.95% <0.00%> (+0.57%)	⬆️

[import-brain]

@xDivisionByZerox Would you prefer I write a test case for the deprecation log, or is it fine in this case?

[xDivisionByZerox]

Normally our procedure when deprecating something consists of 3 steps:

1. Use the internal deprecated function
2. Add a @deprecated JSDoc parameter
3. Add a test case that ensures that the deprecation log is being printed to the console

So I guess to be exact a test would be required, if you don't mind.

[import-brain]

Normally our procedure when deprecating something consists of 3 steps:

1. Use the internal deprecated function
2. Add a @deprecated JSDoc parameter
3. Add a test case that ensures that the deprecation log is being printed to the console

So I guess to be exact a test would be required, if you don't mind.

Sure, I'll get on it :)

outdated