chore(lorempixel.avatar): deprecate #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import-brain
added
c: chore
Codecov Report
@@ Coverage Diff @@
## main #1069 +/- ##
=======================================
Coverage ? 99.64%
=======================================
Files ? 2135
Lines ? 229170
Branches ? 978
=======================================
Hits ? 228365
Misses ? 784
Partials ? 21
|
ST-DDT
previously approved these changes
Jun 14, 2022
Shinigami92
requested changes
Jun 14, 2022
There was a problem hiding this comment.
Please revert test/image.spec.ts due to we don't need direct deprecation tests anymore
@ST-DDT wrote a test that checks every @deprecated and @example JSDoc tags automatically 🚀
xDivisionByZerox
previously approved these changes
Jun 14, 2022
import-brain
dismissed stale reviews from xDivisionByZerox and ST-DDT
via
0bf07dc
Shinigami92
previously approved these changes
Jun 14, 2022
ST-DDT
reviewed
Jun 14, 2022
ST-DDT
previously approved these changes
Jun 14, 2022
Shinigami92
previously approved these changes
Jun 15, 2022
xDivisionByZerox
previously approved these changes
Jun 16, 2022
|
Is something blocking the merge of this? |
xDivisionByZerox
force-pushed
the
chore/lorempixel/deprecate-avatar
branch
from
345028a to
ace5b06
Compare
ST-DDT
approved these changes
Jun 16, 2022
Only missing free time.^^ |
Shinigami92
dismissed stale reviews from xDivisionByZerox and themself
via
ace5b06
Shinigami92
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listed as a todo in #1044
Deprecates
lorempixel.avatar()in favor ofinternet.avatar()