Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(random.alpha): remove todo comment #1089

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Jun 18, 2022

Is listed in #1044.
But, this comment seems to be outdated.

@xDivisionByZerox xDivisionByZerox added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Jun 18, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jun 18, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team June 18, 2022 11:49
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner June 18, 2022 11:49
@xDivisionByZerox xDivisionByZerox self-assigned this Jun 18, 2022
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1089 (df17634) into main (080e51d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2135     2135              
  Lines      229241   229240       -1     
  Branches      979      978       -1     
==========================================
- Hits       228429   228426       -3     
- Misses        791      793       +2     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/random/index.ts 98.14% <ø> (-0.01%) ⬇️
src/modules/internet/user-agent.ts 86.37% <0.00%> (-0.58%) ⬇️

@Shinigami92 Shinigami92 enabled auto-merge (squash) June 18, 2022 14:26
@Shinigami92 Shinigami92 merged commit 77c609e into main Jun 18, 2022
@Shinigami92 Shinigami92 deleted the chore/random/remove-todo branch June 18, 2022 14:35
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added the m: random Something is referring to the random module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior m: random Something is referring to the random module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants