Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing unpredictable emails and usernames #1115

Merged
merged 6 commits into from
Jun 30, 2022

Conversation

kris71990
Copy link
Contributor

Added more specific regexes to test email and username creation

Re: #1044

@kris71990 kris71990 requested a review from a team as a code owner June 28, 2022 23:12
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #1115 (52678da) into main (1cb9312) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1115   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2146     2146           
  Lines      230393   230393           
  Branches      977      978    +1     
=======================================
+ Hits       229577   229580    +3     
+ Misses        795      792    -3     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 87.24% <0.00%> (+0.86%) ⬆️

@ejcheng ejcheng requested a review from a team June 29, 2022 03:54
@ejcheng ejcheng added this to the v7 - Current Major milestone Jun 29, 2022
@Shinigami92 Shinigami92 requested a review from ST-DDT June 29, 2022 07:11
Co-authored-by: Leyla Jähnig <leyla.jaehnig@gmx.de>
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 30, 2022 10:36
@Shinigami92 Shinigami92 merged commit e5ebaef into faker-js:main Jun 30, 2022
@kris71990 kris71990 deleted the username-tests branch June 30, 2022 18:30
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
Co-authored-by: Leyla Jähnig <leyla.jaehnig@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@xDivisionByZerox xDivisionByZerox added the m: internet Something is referring to the internet module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test m: internet Something is referring to the internet module
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants