Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(system.networkInterface): add networkInterface faker #1133

Merged
merged 8 commits into from
Aug 4, 2022
Merged

feat(system.networkInterface): add networkInterface faker #1133

merged 8 commits into from
Aug 4, 2022

Conversation

iandrewt
Copy link
Contributor

@iandrewt iandrewt commented Jul 7, 2022

I built this to use in one of my own projects, based on the SystemD predictable network interface device names schema (although this is likely the antithesis of that 😛 ). Figured it might be worth sharing, but if it's too niche then no hard feelings 😄

@iandrewt iandrewt requested a review from a team as a code owner July 7, 2022 23:26
ST-DDT
ST-DDT reviewed Jul 8, 2022
View reviewed changes
src/modules/system/index.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 8, 2022 •
edited
Loading

Codecov Report

Merging #1133 (6ea271c) into main (407466f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1133   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2155     2155           
  Lines      236831   236900   +69     
  Branches      979      989   +10     
=======================================
+ Hits       235942   236011   +69     
  Misses        868      868           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/system/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added c: feature Request for new feature p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision labels Jul 8, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Jul 8, 2022
@ST-DDT ST-DDT added s: needs decision Needs team/maintainer decision and removed s: needs decision Needs team/maintainer decision labels Jul 8, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Jul 8, 2022

Preview: ✅

grafik

ST-DDT
ST-DDT previously approved these changes Jul 8, 2022
View reviewed changes
@ST-DDT ST-DDT requested review from a team July 8, 2022 22:43
Shinigami92
Shinigami92 previously approved these changes Jul 8, 2022
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not really happy what prettier does for the formatting here but that is not the authors problem
Also the test regex are very heavy, but they work
The PR works, so I will approve

@xDivisionByZerox xDivisionByZerox added the m: system Something is referring to the system module label Jul 28, 2022
ejcheng
ejcheng requested changes Aug 2, 2022
View reviewed changes
Copy link
Member

@ejcheng ejcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the tests, some are running red.

@Shinigami92 Shinigami92 dismissed stale reviews from ST-DDT and themself via ee8b99b August 2, 2022 16:30
Shinigami92
Shinigami92 reviewed Aug 2, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Aug 2, 2022
View reviewed changes
test/system.spec.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested a review from ejcheng August 3, 2022 14:03
@Shinigami92 Shinigami92 requested a review from ST-DDT August 4, 2022 07:06
@Shinigami92 Shinigami92 removed the s: needs decision Needs team/maintainer decision label Aug 4, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 4, 2022 14:45
@Shinigami92 Shinigami92 merged commit 5979f82 into faker-js:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

Assignees

@iandrewt iandrewt

Labels
c: feature Request for new feature m: system Something is referring to the system module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
5 participants
@iandrewt @ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox