Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): add male_first_name,female_first_name, jp locale #1217

Merged
merged 4 commits into from
Aug 2, 2022
Merged

feat(dev): add male_first_name,female_first_name, jp locale #1217

merged 4 commits into from
Aug 2, 2022

Conversation

satoc0629
Copy link
Contributor

No description provided.

@satoc0629 satoc0629 requested a review from a team as a code owner July 31, 2022 13:41
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Jul 31, 2022
@xDivisionByZerox xDivisionByZerox added this to the v7 - Current Major milestone Jul 31, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team July 31, 2022 13:45
@codecov
Copy link

codecov bot commented Jul 31, 2022 •
edited
Loading

Codecov Report

Merging #1217 (c4cbf6d) into main (5a397e0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1217      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2153     2155       +2     
  Lines      236543   236831     +288     
  Branches      980      984       +4     
==========================================
+ Hits       235655   235967     +312     
+ Misses        867      843      -24     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/ja/name/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/ja/name/index.ts 100.00% <100.00%> (ø)
src/locales/ja/name/male_first_name.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

ST-DDT
ST-DDT approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed using google translate. Looks good to me.

@ST-DDT ST-DDT requested a review from a team August 1, 2022 17:26
ejcheng
ejcheng approved these changes Aug 1, 2022
View reviewed changes
Copy link
Member

@ejcheng ejcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also reviewed using Google Translate, lgtm

@ST-DDT ST-DDT enabled auto-merge (squash) August 2, 2022 08:33
@ST-DDT ST-DDT merged commit ad885ea into faker-js:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejcheng ejcheng ejcheng approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@satoc0629 satoc0629

Labels
c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
5 participants
@satoc0629 @ST-DDT @Shinigami92 @ejcheng @xDivisionByZerox