Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale(pl): add extra colors and sort lines #1226

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

hankucz
Copy link
Contributor

@hankucz hankucz commented Aug 3, 2022

No description provided.

@hankucz hankucz requested a review from a team as a code owner August 3, 2022 19:14
@ejcheng ejcheng requested a review from a team August 3, 2022 19:21
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@dd73ad8). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 7ccda7b differs from pull request most recent head 4897ef8. Consider uploading reports for the commit 4897ef8 to get more accurate results

@@           Coverage Diff           @@
##             main    #1226   +/-   ##
=======================================
  Coverage        ?   99.63%           
=======================================
  Files           ?     2155           
  Lines           ?   236833           
  Branches        ?      984           
=======================================
  Hits            ?   235969           
  Misses          ?      843           
  Partials        ?       21           
Impacted Files Coverage Δ
src/locales/pl/color/human.ts 100.00% <100.00%> (ø)

@ejcheng ejcheng added the c: locale Permutes locale definitions label Aug 3, 2022
@ejcheng ejcheng added this to the v7 - Current Major milestone Aug 3, 2022
@pkuczynski pkuczynski changed the title chore(locales.pl): add extra colors in pl translation and sort lines chore(locales.pl): add extra colors and sort lines Aug 3, 2022
@ST-DDT ST-DDT requested review from a team August 3, 2022 21:01
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: color Something is referring to the color module labels Aug 3, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Aug 3, 2022

Should we use locale(pl): add extra colors and sort lines as a way to name these locale only PRs?
That way it would be easier to spot in the changelogs.

@Shinigami92
Copy link
Member

Should we use locale(pl): add extra colors and sort lines as a way to name these locale only PRs? That way it would be easier to spot in the changelogs.

It's needed to be allowed here: https://github.com/faker-js/faker/blob/main/.github/semantic.yml

@ST-DDT ST-DDT changed the title chore(locales.pl): add extra colors and sort lines locale(pl): add extra colors and sort lines Aug 5, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) August 5, 2022 06:48
@ST-DDT ST-DDT merged commit 0e36c30 into faker-js:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: color Something is referring to the color module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants