Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add horses to pl #1227

Merged
merged 4 commits into from
Aug 19, 2022
Merged

feat(locale): add horses to pl #1227

merged 4 commits into from
Aug 19, 2022

Conversation

hankucz
Copy link
Contributor

@hankucz hankucz commented Aug 3, 2022

No description provided.

@hankucz hankucz requested a review from a team as a code owner August 3, 2022 19:17
@import-brain import-brain requested a review from a team August 3, 2022 19:19
@import-brain import-brain added the c: locale Permutes locale definitions label Aug 3, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022 •
edited
Loading

Codecov Report

Merging #1227 (bc1f9c0) into main (7a718b9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #1227    +/-   ##
========================================
  Coverage   99.62%   99.62%            
========================================
  Files        2156     2158     +2     
  Lines      239940   240193   +253     
  Branches     1003     1003            
========================================
+ Hits       239041   239294   +253     
  Misses        878      878            
  Partials       21       21
Impacted Files Coverage Δ
src/locales/pl/animal/horse.ts 100.00% <100.00%> (ø)
src/locales/pl/animal/index.ts 100.00% <100.00%> (ø)
src/locales/pl/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: animal Something is referring to the animal module labels Aug 5, 2022
@ST-DDT ST-DDT changed the title feat(locales.pl): add pl for horses locale(pl): add horses Aug 5, 2022
@Shinigami92 Shinigami92 changed the title locale(pl): add horses feat(locale): add horses to pl Aug 12, 2022
@ST-DDT
Copy link
Member

ST-DDT commented Aug 16, 2022

@hankucz Could you please perform the requested changes so we can merge this?

@Shinigami92
Copy link
Member

@xDivisionByZerox did you progress on a PR for checking alphabetically sorted locales?
I think we should test it and add a manual filtering step to define if we want to list some specific cases where sorting doesn't make sense (like direction)

@hankucz
Copy link
Contributor Author

hankucz commented Aug 18, 2022

@ST-DDT feedback applied

@hankucz hankucz requested a review from pkuczynski August 18, 2022 20:41
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 19, 2022 07:23
@Shinigami92 Shinigami92 merged commit ca7cb41 into faker-js:main Aug 19, 2022
@xDivisionByZerox xDivisionByZerox mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@pkuczynski pkuczynski pkuczynski approved these changes

Assignees

@hankucz hankucz

Labels
c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
5 participants
@hankucz @ST-DDT @Shinigami92 @pkuczynski @import-brain