-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: searchable api #1253
docs: searchable api #1253
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 2160 2160
Lines 240431 240431
Branches 1008 1006 -2
==========================================
- Hits 239542 239532 -10
- Misses 868 878 +10
Partials 21 21
|
Amazing! Do we want to search for only the names or do we also want to search for some (hidden) aliases/tags? |
thx :3
Not sure, I would start with simple solution |
I think we already have the normalization somewhere for the api docs themselves. faker/scripts/apidoc/moduleMethods.ts Line 37 in e5951c0
Maybe we should extract it to a separate method (normalizeModuleName). For method names we have that to a certain extend already: faker/scripts/apidoc/signature.ts Line 30 in e5951c0
(We might have to separate between id-names and title-names though) |
Okay, I think I need to generate at build-time a data json for the search page, because I would like to prevent the need of recreating the search data object everytime someone visit the search page on their client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocked by #1272 and then it needs to be rebased to use the new methods so we have consistent api docs and search index.
e0055f1
to
9687fdf
Compare
34ac9bf
to
56b1c22
Compare
This is a draft to make the API searchable like https://vuejs.org/api/