refactor(unique): move to helpers #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
Codecov Report
@@ Coverage Diff @@
## main #1298 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2160 2160
Lines 240491 240541 +50
Branches 1009 1010 +1
=======================================
+ Hits 239584 239634 +50
Misses 886 886
Partials 21 21
|
ST-DDT
reviewed
Aug 24, 2022
Shinigami92
previously requested changes
Aug 25, 2022
Shinigami92
approved these changes
Aug 27, 2022
ST-DDT
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
unique()method from theUniquemodule into theHelpersmodule. There is no reason for it being a standalone module when it is clearly a utility method.This was discussed in #805 (direct link).