-
-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: set renovate schedule to weekly #1302
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.01%
==========================================
Files 2160 2160
Lines 240444 240444
Branches 1010 1006 -4
==========================================
- Hits 239564 239540 -24
- Misses 859 883 +24
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use just: https://docs.renovatebot.com/presets-schedule/#scheduleweekly
I don't see why. Cron expressions are a known standard for developers (at least to some degree). This language thing seems nice for readability purposes but has no documentation whatsoever. I also really dislike the idea of expressing what I want in plain English and a machine gets what I want. I'll not block this, because if this. I just don't see the reason why this would be a required change for a merge on this PR. |
Everyone using renovate is using this syntax
And what do you mean by not documented? I linked you the documentation ^^ |
So what does the syntax translates to when I write the following
Does this run at all? That's what I mean by documented. You linked just a bunch of examples that are marked as "documentation". If I can just write plain English, what words do actually get picked up for the expression? But whatever, I will just change the expression. |
If your have such specific standards to workflow configuration or code standards in general please don't ask next time in the meeting who whats to take the task if you insist on doing it your way :) |
But then I couldn't approve it and would need to ask another reviewer 🙈 Beside that, I thought it would be to easy... didn't even thought that they support cron |
This PR changes the interval from "at any time" to a weekly basis every Monday morning via a cron expression.
Important reference links: