Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: set renovate schedule to weekly #1302

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Conversation

xDivisionByZerox
Copy link
Member

This PR changes the interval from "at any time" to a weekly basis every Monday morning via a cron expression.

Important reference links:

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Aug 25, 2022
@xDivisionByZerox xDivisionByZerox requested a review from a team August 25, 2022 18:38
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner August 25, 2022 18:38
@xDivisionByZerox xDivisionByZerox self-assigned this Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1302 (ff2d5fd) into main (a734ca0) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2160     2160              
  Lines      240444   240444              
  Branches     1010     1006       -4     
==========================================
- Hits       239564   239540      -24     
- Misses        859      883      +24     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 81.74% <0.00%> (-6.35%) ⬇️

Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Aug 25, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 25, 2022
@xDivisionByZerox
Copy link
Member Author

Maybe we should use just: https://docs.renovatebot.com/presets-schedule/#scheduleweekly

I don't see why. Cron expressions are a known standard for developers (at least to some degree). This language thing seems nice for readability purposes but has no documentation whatsoever. I also really dislike the idea of expressing what I want in plain English and a machine gets what I want.

I'll not block this, because if this. I just don't see the reason why this would be a required change for a merge on this PR.

@xDivisionByZerox
Copy link
Member Author

So what does the syntax translates to when I write the following

Take yourself 3 out times before midnight but only on a full moon in winter

Does this run at all? That's what I mean by documented. You linked just a bunch of examples that are marked as "documentation". If I can just write plain English, what words do actually get picked up for the expression?

But whatever, I will just change the expression.

.github/renovate.json5 Outdated Show resolved Hide resolved
.github/renovate.json5 Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 requested a review from ST-DDT August 25, 2022 20:40
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 25, 2022 20:41
@Shinigami92 Shinigami92 merged commit 9f8f952 into main Aug 25, 2022
@ST-DDT ST-DDT deleted the infra/renovate-schedule branch August 25, 2022 20:50
@xDivisionByZerox
Copy link
Member Author

If your have such specific standards to workflow configuration or code standards in general please don't ask next time in the meeting who whats to take the task if you insist on doing it your way :)

@Shinigami92
Copy link
Member

Shinigami92 commented Aug 25, 2022

If your have such specific standards to workflow configuration or code standards in general please don't ask next time in the meeting who whats to take the task if you insist on doing it your way :)

But then I couldn't approve it and would need to ask another reviewer 🙈

Beside that, I thought it would be to easy... didn't even thought that they support cron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reduce dependency update PRs to once a week
3 participants