Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): extends id_ID company prefix #1399

Merged
merged 3 commits into from
Sep 29, 2022
Merged

feat(locale): extends id_ID company prefix #1399

merged 3 commits into from
Sep 29, 2022

Conversation

fzn0x
Copy link
Contributor

@fzn0x fzn0x commented Sep 27, 2022

Add Fa (Firm), Yayasan (Foundation), and KKB (Koperasi Keluarga Besar)

@fzn0x
feat(id_ID): extends company prefix
14d4ae9 
Add Fa (Firm), Yayasan (Foundation), and KKB (Koperasi Keluarga Besar)
@fzn0x fzn0x requested a review from a team as a code owner September 27, 2022 11:25
@codecov
Copy link

codecov bot commented Sep 27, 2022 •
edited
Loading

Codecov Report

Merging #1399 (35f735e) into main (be87581) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1399   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2163     2163           
  Lines      241306   241306           
  Branches     1017     1018    +1     
=======================================
+ Hits       240399   240406    +7     
+ Misses        886      879    -7     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/id_ID/company/prefix.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 83.59% <0.00%> (+1.85%) ⬆️

@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: locale Permutes locale definitions m: company Something is referring to the company module labels Sep 27, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Sep 27, 2022
ST-DDT
ST-DDT reviewed Sep 27, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a source for this information, so that we can easily verify them.

@fzn0x
Copy link
Contributor Author

fzn0x commented Sep 28, 2022

Please provide a source for this information, so that we can easily verify them.

Sure, I will give you the source for this.

Fa: https://id.wikipedia.org/wiki/Firma
Yayasan: https://id.wikipedia.org/wiki/Yayasan
KKB: this is the less known one, this is the examples of the companies using the prefix =

@Shinigami92 Shinigami92 changed the title feat(id_ID): extends company prefix feat(locale): extends id_ID company prefix Sep 29, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 29, 2022 14:18
@Shinigami92 Shinigami92 merged commit f410564 into faker-js:main Sep 29, 2022
@fzn0x fzn0x deleted the patch-2 branch September 29, 2022 17:25
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@fzn0x @wael-fadlallah
feat(locale): extends id_ID company prefix (faker-js#1399)
209ce4d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@fzn0x fzn0x

Labels
c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.
3 participants
@fzn0x @ST-DDT @Shinigami92