Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lorem null response fix #1407

Merged
merged 10 commits into from
Oct 9, 2022
Merged

feat: lorem null response fix #1407

merged 10 commits into from
Oct 9, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 2, 2022

Fixes #1131

  • Extended and exported the filterWordListByLength to add support for length ranges and fallback strategies
  • Use the improved filterWordListByLength function for all word.* and lorem.word methods

@ST-DDT ST-DDT added c: bug Something isn't working c: feature Request for new feature p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug m: lorem Something is referring to the lorem module m: word Something is referring to the word module labels Oct 2, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Oct 2, 2022
@ST-DDT ST-DDT requested review from a team October 2, 2022 19:53
@ST-DDT ST-DDT self-assigned this Oct 2, 2022
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #1407 (0111b9b) into main (5dc8f0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1407    +/-   ##
========================================
  Coverage   99.61%   99.61%            
========================================
  Files        2165     2166     +1     
  Lines      237194   237442   +248     
  Branches     1017     1040    +23     
========================================
+ Hits       236287   236535   +248     
  Misses        886      886            
  Partials       21       21            
Impacted Files Coverage Δ
src/modules/lorem/index.ts 100.00% <100.00%> (ø)
src/modules/word/filterWordListByLength.ts 100.00% <100.00%> (ø)
src/modules/word/index.ts 100.00% <100.00%> (ø)

src/modules/lorem/index.ts Outdated Show resolved Hide resolved
src/modules/word/filterWordListByLength.ts Outdated Show resolved Hide resolved
src/modules/word/filterWordListByLength.ts Outdated Show resolved Hide resolved
src/modules/word/filterWordListByLength.ts Outdated Show resolved Hide resolved
src/modules/word/filterWordListByLength.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested a review from Shinigami92 October 2, 2022 21:59
@ST-DDT ST-DDT requested a review from Shinigami92 October 2, 2022 22:09
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 3, 2022

Docs-Preview (Click to expand)

grafik

Shinigami92
Shinigami92 previously approved these changes Oct 3, 2022
import-brain
import-brain previously approved these changes Oct 3, 2022
@ST-DDT ST-DDT requested review from a team, Shinigami92 and import-brain and removed request for a team October 3, 2022 13:31
@Shinigami92
Copy link
Member

Looks like needs a rebase

@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 8, 2022

Updated

@ST-DDT ST-DDT merged commit a6ce717 into main Oct 9, 2022
@ST-DDT ST-DDT deleted the feat/lorem-null-response-fix branch October 9, 2022 19:26
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working c: feature Request for new feature m: lorem Something is referring to the lorem module m: word Something is referring to the word module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

faker.lorem.word can return undefined despite being typed as string
3 participants