Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-enable sanitizeHtml check #1500

Merged
merged 5 commits into from
Nov 21, 2022
Merged

chore: re-enable sanitizeHtml check #1500

merged 5 commits into from
Nov 21, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 30, 2022 •
edited
Loading

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Oct 30, 2022
@ST-DDT ST-DDT requested review from a team October 30, 2022 17:03
@ST-DDT ST-DDT self-assigned this Oct 30, 2022
@ST-DDT
Copy link
Member Author

ST-DDT commented Oct 30, 2022

I have to update the snapshots, but that would cause merge conflicts with #1488, so I mark this one as blocked until it is merged.

@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Oct 30, 2022
@ST-DDT ST-DDT force-pushed the docs/reenable-sanitize-check branch from c7a1b2c to f7edff7 Compare November 9, 2022 22:59
@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Merging #1500 (23afeb4) into next (f9a44c8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1500   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2216     2216           
  Lines      238921   238921           
  Branches     1039     1039           
=======================================
  Hits       238059   238059           
  Misses        841      841           
  Partials       21       21

@ST-DDT
Copy link
Member Author

ST-DDT commented Nov 9, 2022

Ready for review.

@ST-DDT ST-DDT enabled auto-merge (squash) November 21, 2022 18:30
@ST-DDT ST-DDT merged commit f30c111 into next Nov 21, 2022
@ST-DDT ST-DDT deleted the docs/reenable-sanitize-check branch November 21, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Sanitize html in docs
3 participants
@ST-DDT @Shinigami92 @ejcheng