chore: remove broken source urls found in some locales #1511
Conversation
ST-DDT
added
c: chore
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1511 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2214 2214
Lines 238758 238725 -33
Branches 1015 1016 +1
=======================================
- Hits 237902 237872 -30
+ Misses 835 832 -3
Partials 21 21
|
|
I mean, the source comment was there for a reason...if we remove it from the locales the maintainer team should decide on an alternative strategy to provide intel on how faker data is populated (what qualifies to be taken into a source set). |
|
@xDivisionByZerox It is not about removing all source links. These links are broken and I don't have any hope of any of them coming back online. |
Ah, ok, my bad. That intend wasn't clear for me from the PRs description. |
I updated it to make it more clear. |
ST-DDT
changed the title
|
Rather than completely remove these comments, perhaps it could just be replaced with
That keeps the data attributed, and if someone wants to come along and update to a newer version of CLDR later, they can. |
Good idea! |
|
My main problem with that is that it only links to a few zip files and it is not clear which file to actually look into. So at least we have to point to a specific zip with the actual file inside the zip added in parenthesis. |
|
more recent versions of CLDR are in Github, e.g. https://github.com/unicode-org/cldr/blob/main/common/main/de.xml so someone could probably go cross-check and restore correct line numbers later (or write a script to grab data directly from CLDR). |
IMO this should be done immediately using githup perma links. But we should keep that idea in mind/create an issue for updating the calendar entries if possible. |
|
im pretty sure a lot of the line numbers are wrong anyway, for example many languages have a comment with |
|
I would use the links to GitHub and create a ticket to fetch it via script scheduled in CI |
|
if someone wants to take that up in future note there's a JSON version generated from the XML versions which is probably easier to consume. https://github.com/unicode-org/cldr-json |
Updated date files to remove the broken source links found in the following locales: