-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: delete old examples and doc folder #155
Conversation
✔️ Deploy Preview for vigilant-wescoff-04e480 ready! 🔨 Explore the source changes: 29edcd6 🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61eab37a1a5f0800077a55ac 😎 Browse the preview: https://deploy-preview-155--vigilant-wescoff-04e480.netlify.app |
Good idea to delete them |
I see you also deleted the examples folder 🤔 Did you also check that the |
I plan to write integration tests for parts of the docs at least. We can use the playground for that. |
4774401
to
889fbd3
Compare
@Shinigami92 I did verify the removal of the examples from the gulpfile. https://github.com/faker-js/faker/pull/155/files#diff-5389b9382804b62e7e964159df7c0c792dffb0705a48429d96d1aacd830aef09L28 |
Let's rebase this PR after we merged #235 |
889fbd3
to
2a1d3c6
Compare
was not working anyways and we will write other modern automatisations later anyways
I additionally cleaned up some files, so this is not just deleting the |
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
The new docs can be found in the
docs
folder.