Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete old examples and doc folder #155

Merged
merged 4 commits into from
Jan 21, 2022
Merged

chore: delete old examples and doc folder #155

merged 4 commits into from
Jan 21, 2022

Conversation

damienwebdev
Copy link
Member

The new docs can be found in the docs folder.

@netlify
Copy link

netlify bot commented Jan 15, 2022

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 29edcd6

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61eab37a1a5f0800077a55ac

😎 Browse the preview: https://deploy-preview-155--vigilant-wescoff-04e480.netlify.app

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 15, 2022
@Shinigami92
Copy link
Member

Good idea to delete them
Even if we need them, we can just access git history 👍

@Shinigami92
Copy link
Member

I see you also deleted the examples folder 🤔
We should look if there is somewhere a test or we need to write a test to test that it works in the browser.
Alternative we could say for now we don't support browser version 🤔

Did you also check that the examples/browser/js/faker(.min).js files are not generated anymore by scripts?
Maybe we can also remove some stuff from gitignore and such.

@prisis prisis added this to the v6.0.0 milestone Jan 16, 2022
@Shinigami92 Shinigami92 requested a review from a team January 16, 2022 16:30
@JessicaSachs
Copy link
Contributor

I plan to write integration tests for parts of the docs at least. We can use the playground for that.

@damienwebdev
Copy link
Member Author

import-brain
import-brain previously approved these changes Jan 20, 2022
@Shinigami92
Copy link
Member

image

Let's rebase this PR after we merged #235

was not working anyways and we will write other modern automatisations later anyways
@Shinigami92
Copy link
Member

I additionally cleaned up some files, so this is not just deleting the doc and examples folder but also format not formatted files and removed the old logo.png

@prisis prisis self-requested a review January 21, 2022 17:36
@Shinigami92 Shinigami92 mentioned this pull request Jan 21, 2022
@Shinigami92 Shinigami92 merged commit 51a95d8 into main Jan 21, 2022
@Shinigami92 Shinigami92 deleted the remove_old_doc branch January 21, 2022 18:19
pkuczynski pushed a commit to pkuczynski/faker that referenced this pull request Jan 21, 2022
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants