Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(string): rename params #1551

Merged
merged 7 commits into from
Nov 14, 2022
Merged

refactor(string): rename params #1551

merged 7 commits into from
Nov 14, 2022

Conversation

ejcheng
Copy link
Member

@ejcheng ejcheng commented Nov 12, 2022

closes #1465

@ejcheng ejcheng added s: accepted Accepted feature / Confirmed bug c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module labels Nov 12, 2022
@ejcheng ejcheng added this to the v8.0 - Module Re-Shuffling milestone Nov 12, 2022
@ejcheng ejcheng requested a review from a team November 12, 2022 00:32
@ejcheng ejcheng self-assigned this Nov 12, 2022
@ejcheng ejcheng requested a review from a team as a code owner November 12, 2022 00:32
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited
Loading

Codecov Report

Merging #1551 (1f03e34) into next (66ccca3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1f03e34 differs from pull request most recent head 06b0371. Consider uploading reports for the commit 06b0371 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1551   +/-   ##
=======================================
  Coverage   99.63%   99.64%           
=======================================
  Files        2214     2214           
  Lines      238812   238816    +4     
  Branches     1029     1032    +3     
=======================================
+ Hits       237950   237972   +22     
+ Misses        841      823   -18     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/random/index.ts 99.00% <100.00%> (+0.01%) ⬆️
src/modules/string/index.ts 100.00% <100.00%> (ø)
src/modules/vehicle/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 97.35% <0.00%> (+4.76%) ⬆️

ST-DDT
ST-DDT requested changes Nov 12, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the obsolete test snapshots.

Also we should adjust the jsdocs and error messages to use the new term.

src/modules/random/index.ts Outdated Show resolved Hide resolved
src/modules/vehicle/index.ts Outdated Show resolved Hide resolved
Shinigami92
Shinigami92 previously approved these changes Nov 12, 2022
View reviewed changes
ST-DDT
ST-DDT previously approved these changes Nov 12, 2022
View reviewed changes
src/modules/string/index.ts Outdated Show resolved Hide resolved
@ejcheng ejcheng dismissed stale reviews from ST-DDT and Shinigami92 via 1f03e34 November 13, 2022 05:11
@ST-DDT ST-DDT changed the title refactor: rename params in string module refactor(string): rename params Nov 14, 2022
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Nov 14, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) November 14, 2022 22:52
@ST-DDT ST-DDT merged commit 801e9e0 into next Nov 14, 2022
@Shinigami92 Shinigami92 deleted the refactor/rename_string_module_params branch November 15, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees

@ejcheng ejcheng

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: string Something is referring to the string module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.

Rename bannedChars and bannedDigits in string module
3 participants
@ejcheng @ST-DDT @Shinigami92