-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: run tests shuffled #1645
test: run tests shuffled #1645
Conversation
While this seems to solve the issue of testing always with the same values, it also renders our random seeded tests useless, because the tests are no longer reproducible (by setting the previous/failing seed) in case they uncover a test failure. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1645 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2346 2346
Lines 235002 235002
Branches 1133 1132 -1
==========================================
- Hits 234147 234138 -9
- Misses 833 842 +9
Partials 22 22
|
I assume this still is likely to use seeds values close to our seeded tests (fixed seed + 1 or 2 calls). |
ff74ae2
Uh damn it, I accidentally pushed it directly to this PR 🤷 |
closes #1318
Waiting on merge of:
This PR configured vitest to run the tests in shuffled mode
https://vitest.dev/config/#sequence-shuffle