Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: don't fail when updating snapshots #1656

Merged
merged 2 commits into from
Dec 12, 2022
Merged

infra: don't fail when updating snapshots #1656

merged 2 commits into from
Dec 12, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 11, 2022

In #1633 I noticed that there wasn't any message due to outdated snapshots.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Dec 11, 2022
@ST-DDT ST-DDT self-assigned this Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #1656 (77c7548) into next (49fcb3b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1656   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files        2221     2221           
  Lines      240110   240110           
  Branches     1049     1050    +1     
=======================================
+ Hits       239238   239241    +3     
+ Misses        851      848    -3     
  Partials       21       21           
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 84.86% <0.00%> (+0.81%) ⬆️

@ST-DDT ST-DDT marked this pull request as ready for review December 11, 2022 17:30
@ST-DDT ST-DDT requested a review from a team as a code owner December 11, 2022 17:30
@ST-DDT ST-DDT requested a review from a team December 11, 2022 17:31
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Dec 12, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) December 12, 2022 15:37
@ST-DDT ST-DDT merged commit b2a72bc into next Dec 12, 2022
@Shinigami92 Shinigami92 deleted the infra/ci/pr-generate branch December 12, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants