Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): update location/country list #1676

Merged
merged 3 commits into from
Dec 24, 2022

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Dec 20, 2022

Modernise the country list
https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

Note this is really "ISO 3166 countries" which includes dependencies etc.

Note that existing countries seem to avoid diacritics (Cote d'Ivoire not Côte d'Ivoire etc so I stuck with that for the time being, Åland and Curaçao would be more correct. If you think adding diacritics would be an improvement that could be added as a new PR.)

Added

Aland Islands (seemingly missed off)
Democratic Republic of the Congo (seemingly missed off? This is a different country to Congo)
South Sudan (since 2011)

Broken up

Removed Netherlands Antilles which was dissolved in 2010 (see https://en.wikipedia.org/wiki/Netherlands_Antilles) and added

Bonaire, Sint Eustatius and Saba
Curacao
Sint Maarten

Aruba already has its own entry

Official renamings

Swaziland to Eswatini (2018)
Czech Republic to Czechia (2016)
Macedonia to North Macedonia (2019)
Palestinian Territory to Palestine (2012)

Simplifications where Faker was using a long or non-standard name

Antarctica (the territory South of 60 deg S) to Antarctica
Bouvet Island (Bouvetoya) to Bouvet Island
Slovakia (Slovak Republic) to Slovakia

@matthewmayer matthewmayer marked this pull request as ready for review December 20, 2022 04:09
@matthewmayer matthewmayer requested a review from a team as a code owner December 20, 2022 04:10
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #1676 (876857a) into next (dd81fe1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1676   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2240     2240           
  Lines      240286   240291    +5     
  Branches     1072     1072           
=======================================
+ Hits       239427   239432    +5     
  Misses        838      838           
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/en/location/country.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT requested review from a team December 20, 2022 09:08
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Dec 20, 2022
@ST-DDT ST-DDT enabled auto-merge (squash) December 24, 2022 01:39
@ST-DDT ST-DDT merged commit ce1fa2f into faker-js:next Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants