-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(location): use IANA standard for timezone #1678
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1678 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 2244 2240 -4
Lines 240509 240286 -223
Branches 1072 1072
==========================================
- Hits 239650 239427 -223
Misses 838 838
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now this is okay, but in #735 we need to move it out of en
into a global thingy
I was questioning if I should mark that in this PR. @matthewmayer do you want to do that as well? Otherwise I could do that, should be easy enough. |
maybe locales might want to override this in future? Like en_AU could return only Australian timezones |
|
fix #734
I generated this using a library which already parses the official tzdb data and therefore contains all valid tz names.
I also deleted the list from other locales except
en
since these were just duplicates of the global list (in theoryanother locale might want to have its own list, e.g. en_AU could return only Australian timestamps?)