refactor(location): nearbyGPSCoordinate options #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
c: refactor
|
@ST-DDT while running - nearbyGPSCoordinate
/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:238
(property.type as ReflectionType)?.declaration.signatures?.[0]
^
TypeError: Cannot read properties of undefined (reading 'signatures')
at <anonymous> (/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:238:48)
at Array.map (<anonymous>)
at analyzeParameterOptions (/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:231:23)
at <anonymous> (/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:227:7)
at Array.flatMap (<anonymous>)
at analyzeParameterOptions (/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:226:32)
at analyzeParameter (/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:210:22)
at analyzeSignature (/home/shinigami/OpenSource/faker/scripts/apidoc/signature.ts:128:20)
at processModuleMethod (/home/shinigami/OpenSource/faker/scripts/apidoc/moduleMethods.ts:77:18)
at processModuleMethods (/home/shinigami/OpenSource/faker/scripts/apidoc/moduleMethods.ts:34:19)can you help me fix this? |
|
This error is shown if there is a param without jsdocs. We could try to improve the error message, but not sure what information we have in that context. options vs optionsOrCoordinate |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1682 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 2245 2245
Lines 240318 240400 +82
Branches 1078 1079 +1
==========================================
+ Hits 239453 239525 +72
- Misses 844 854 +10
Partials 21 21
|
I will extract to an issue |
xDivisionByZerox
previously approved these changes
Dec 26, 2022
import-brain
previously approved these changes
Dec 29, 2022
ST-DDT
reviewed
Dec 29, 2022
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Shinigami92
dismissed stale reviews from import-brain and xDivisionByZerox
via
30aad24
Co-authored-by: Leyla Jähnig <leyla.jaehnig@gmx.de>
ST-DDT
approved these changes
Dec 30, 2022
import-brain
approved these changes
Jan 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1349
preparation for
address.nearbyGPSCoordinate#1357