Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add Luxembourg (French) locale #1693

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

DavidMoraisFerreira
Copy link
Contributor

Adds Luxembourgish locale.

Please note that I had to commit using --no-verify, as lint-staged kept failing with "no valid configuration found."

@DavidMoraisFerreira DavidMoraisFerreira requested a review from a team December 26, 2022 21:49
@DavidMoraisFerreira DavidMoraisFerreira requested a review from a team as a code owner December 26, 2022 21:49
ST-DDT
ST-DDT previously approved these changes Dec 26, 2022
@ST-DDT ST-DDT added c: locale Permutes locale definitions p: 1-normal Nothing urgent labels Dec 26, 2022
@ST-DDT ST-DDT requested review from a team December 26, 2022 22:31
@ST-DDT
Copy link
Member

ST-DDT commented Dec 27, 2022

Please note that I had to commit using --no-verify, as lint-staged kept failing with "no valid configuration found."

You probably have to remove the git now obsolete commit hooks files: rm -rf .git/hooks.


Please run pnpm run test -u to update the test snapshots.

@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Merging #1693 (35c0512) into next (2a06b6a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1693      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2249     2262      +13     
  Lines      240573   240707     +134     
  Branches     1095     1095              
==========================================
+ Hits       239698   239825     +127     
- Misses        854      861       +7     
  Partials       21       21              
Impacted Files Coverage Δ
src/locale/fr_LU.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/cell_phone/formats.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/index.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/internet/index.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/location/city.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/location/city_name.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/location/index.ts 100.00% <100.00%> (ø)
src/locales/fr_LU/location/postcode.ts 100.00% <100.00%> (ø)
... and 5 more

@ST-DDT ST-DDT enabled auto-merge (squash) January 5, 2023 23:05
@ST-DDT ST-DDT merged commit c66f7bd into faker-js:next Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants