-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(string): add binary and octal random string generation #1710
feat(string): add binary and octal random string generation #1710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially octal and binary seem to have a multitude of common prefixes, should we use ''
as the default prefix for all of them?
Only one of our methods uses a non-empty prefix (etheriumAddress), all other 5 methods use ''.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1710 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 2249 2249
Lines 240482 240573 +91
Branches 1083 1095 +12
=======================================
+ Hits 239607 239698 +91
Misses 854 854
Partials 21 21
|
Also the |
Please add |
Sure! |
c16ef52
to
f0836be
Compare
f0836be
to
28d4c8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor changes, then we are good to go from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
This PR implements binary and octal random string generation.
Issue: #184
PR that implements this feature in number module: #1708