fix(locale): filter inappropriate words in the en locale #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1745 +/- ##
==========================================
- Coverage 99.63% 99.63% -0.01%
==========================================
Files 2337 2337
Lines 242692 242582 -110
Branches 1098 1098
==========================================
- Hits 241808 241698 -110
Misses 863 863
Partials 21 21
|
ST-DDT
reviewed
Jan 17, 2023
ST-DDT
added
c: bug
|
Thanks for your time for checking the word lists. |
|
Lust means strong sexual desire Lustrous means shiny Different etymologies! I am a native English speaker and I can generally understand why words were removed. |
|
sometimes the words have both innocent and slang meanings, so a |
|
agree with your comments about the variants, i'll go through and have a second pass later. |
ST-DDT
reviewed
Jan 17, 2023
ST-DDT
previously approved these changes
Jan 18, 2023
|
Looks like CI runs into errors |
ST-DDT
requested changes
Jan 18, 2023
ST-DDT
approved these changes
Jan 18, 2023
import-brain
approved these changes
Jan 18, 2023
Shinigami92
approved these changes
Jan 18, 2023
Shinigami92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #1633
I ran the remaining words against https://github.com/zacanger/profane-words and found quite a few more words to remove.
Several of these are borderline, but the existing lists are so long I think there's little disadvantage in removing all of them.