-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: export mergeLocales utility #1751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: chore
PR that doesn't affect the runtime behavior
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
labels
Jan 18, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1751 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2340 2340
Lines 242623 242624 +1
Branches 1103 1103
=======================================
+ Hits 241771 241772 +1
Misses 831 831
Partials 21 21
|
xDivisionByZerox
previously approved these changes
Jan 18, 2023
ejcheng
previously approved these changes
Jan 18, 2023
Shinigami92
previously approved these changes
Jan 21, 2023
Shinigami92
reviewed
Jan 21, 2023
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Good catch |
Shinigami92
approved these changes
Jan 21, 2023
ejcheng
approved these changes
Jan 21, 2023
xDivisionByZerox
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: chore
PR that doesn't affect the runtime behavior
c: locale
Permutes locale definitions
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing export for the
mergeLocales
utility method introduced in #1707 making it usable for our users.