Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export mergeLocales utility #1751

Merged
merged 5 commits into from
Jan 22, 2023
Merged

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 18, 2023

Adds the missing export for the mergeLocales utility method introduced in #1707 making it usable for our users.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jan 18, 2023
@ST-DDT ST-DDT added this to the v8.0 - Module Re-Shuffling milestone Jan 18, 2023
@ST-DDT ST-DDT self-assigned this Jan 18, 2023
@ST-DDT ST-DDT requested a review from a team as a code owner January 18, 2023 01:03
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1751 (b91ba87) into next (f839ae2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1751   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2340     2340           
  Lines      242623   242624    +1     
  Branches     1103     1103           
=======================================
+ Hits       241771   241772    +1     
  Misses        831      831           
  Partials       21       21           
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

@ST-DDT ST-DDT requested review from a team and Shinigami92 January 18, 2023 22:28
@ST-DDT ST-DDT requested a review from a team January 18, 2023 22:47
ejcheng
ejcheng previously approved these changes Jan 18, 2023
Shinigami92
Shinigami92 previously approved these changes Jan 21, 2023
src/index.ts Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 self-requested a review January 21, 2023 17:03
@Shinigami92 Shinigami92 dismissed their stale review January 21, 2023 17:04

see my review

@ST-DDT ST-DDT dismissed stale reviews from ejcheng and xDivisionByZerox via 162bcdd January 21, 2023 17:28
ST-DDT and others added 2 commits January 21, 2023 18:28
@ST-DDT ST-DDT requested review from ejcheng, xDivisionByZerox and a team January 21, 2023 17:28
@ST-DDT
Copy link
Member Author

ST-DDT commented Jan 21, 2023

Good catch

@Shinigami92 Shinigami92 enabled auto-merge (squash) January 22, 2023 14:50
@Shinigami92 Shinigami92 merged commit e675aaa into next Jan 22, 2023
@ST-DDT ST-DDT deleted the chore/export-mergeLocales branch January 22, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants