test: use basic reporter #1763
Merged
test: use basic reporter #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
requested review from
ejcheng,
ST-DDT,
xDivisionByZerox and
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1763 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2340 2340
Lines 242624 242624
Branches 1103 1103
=======================================
Hits 241772 241772
Misses 831 831
Partials 21 21 |
|
I checked locally and the original error is no longer there on my current device. |
|
I tried it on my second device as well as dev containers and am no longer able to reproduce the error described in #1635 . |
ST-DDT
approved these changes
Jan 22, 2023
|
It's okay anyway, |
|
This is so great! I can finally run tests locally without specifying the test file ♥ |
xDivisionByZerox
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1635
This fixes running tests locally
The previous default reporter cleared the console log everytime when to much is going on in the console
But this results in issues with to many tests and it hangs
So this new reporter do what would be done when
CI=truewould be configured and will not clear the screen anymoreIMO this is even a better UX