Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: big api button #1773

Merged
merged 7 commits into from
Jan 26, 2023
Merged

docs: big api button #1773

merged 7 commits into from
Jan 26, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jan 23, 2023

When visiting the fakerjs.dev website I usually want to access the API overview page.
However the API button is only very small in the top-bar or via Guide->Api.
This PR adds a big colorful View API button to the center of the screen.

grafik

Unfortunately, it isn't possible to use a different color than Get Started (and View On Github).

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jan 23, 2023
@ST-DDT ST-DDT requested review from a team January 23, 2023 22:47
@ST-DDT ST-DDT self-assigned this Jan 23, 2023
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1773 (cae88f4) into next (04b4aac) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1773   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files        2340     2340           
  Lines      242669   242669           
  Branches     1111     1111           
=======================================
  Hits       241819   241819           
  Misses        829      829           
  Partials       21       21           

@ST-DDT ST-DDT requested a review from a team January 23, 2023 23:11
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
ST-DDT and others added 2 commits January 24, 2023 23:02
Co-authored-by: Shinigami <chrissi92@hotmail.de>
docs/index.md Outdated Show resolved Hide resolved
Co-authored-by: Matt Mayer <matt@lemi.travel>
@Shinigami92 Shinigami92 requested review from xDivisionByZerox and matthewmayer and removed request for matthewmayer January 25, 2023 17:02
@ST-DDT ST-DDT enabled auto-merge (squash) January 26, 2023 18:56
@ST-DDT ST-DDT added the s: accepted Accepted feature / Confirmed bug label Jan 26, 2023
@ST-DDT ST-DDT disabled auto-merge January 26, 2023 18:57
@ST-DDT ST-DDT enabled auto-merge (squash) January 26, 2023 18:57
@ST-DDT ST-DDT merged commit 86ae8b9 into next Jan 26, 2023
@ST-DDT ST-DDT deleted the docs/big-api-button branch January 26, 2023 19:04
matthewmayer pushed a commit to matthewmayer/faker that referenced this pull request Feb 18, 2023
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Matt Mayer <matt@lemi.travel>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants