-
-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: big api button #1773
Merged
Merged
docs: big api button #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
labels
Jan 23, 2023
xDivisionByZerox
previously approved these changes
Jan 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1773 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2340 2340
Lines 242669 242669
Branches 1111 1111
=======================================
Hits 241819 241819
Misses 829 829
Partials 21 21 |
Shinigami92
reviewed
Jan 24, 2023
Co-authored-by: Shinigami <chrissi92@hotmail.de>
ST-DDT
requested review from
Shinigami92,
matthewmayer,
xDivisionByZerox and
a team
January 24, 2023 22:24
Co-authored-by: Matt Mayer <matt@lemi.travel>
Shinigami92
approved these changes
Jan 25, 2023
Shinigami92
requested review from
xDivisionByZerox and
matthewmayer
and removed request for
matthewmayer
January 25, 2023 17:02
xDivisionByZerox
approved these changes
Jan 25, 2023
matthewmayer
pushed a commit
to matthewmayer/faker
that referenced
this pull request
Feb 18, 2023
Co-authored-by: Shinigami <chrissi92@hotmail.de> Co-authored-by: Matt Mayer <matt@lemi.travel>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: docs
Improvements or additions to documentation
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting the fakerjs.dev website I usually want to access the
API
overview page.However the API button is only very small in the top-bar or via Guide->Api.
This PR adds a big colorful
View API
button to the center of the screen.Unfortunately, it isn't possible to use a different color than
Get Started
(andView On Github
).