Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(git): length for commit sha #1863

Merged
merged 4 commits into from
Feb 22, 2023
Merged

refactor(git): length for commit sha #1863

merged 4 commits into from
Feb 22, 2023

Conversation

Shinigami92
Copy link
Member

references #1346

@Shinigami92 Shinigami92 added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR labels Feb 21, 2023
@Shinigami92 Shinigami92 self-assigned this Feb 21, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 21, 2023 12:23
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #1863 (a9df19f) into next (25bd847) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1863   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2355     2355           
  Lines      236403   236433   +30     
  Branches     1153     1155    +2     
=======================================
+ Hits       235527   235569   +42     
+ Misses        854      842   -12     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/git/index.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 98.92% <0.00%> (+0.21%) ⬆️
src/modules/internet/user-agent.ts 92.30% <0.00%> (+2.95%) ⬆️

@ST-DDT ST-DDT requested review from a team February 22, 2023 15:59
@ST-DDT ST-DDT added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Feb 22, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) February 22, 2023 23:53
@ST-DDT ST-DDT merged commit aa3e771 into next Feb 22, 2023
@ST-DDT ST-DDT deleted the refactor-git-commit-sha branch February 22, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@Shinigami92 Shinigami92

Labels
c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.0 - Module Re-Shuffling
Development

Successfully merging this pull request may close these issues.
3 participants
@Shinigami92 @ST-DDT @ejcheng