Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: error on deprecation #1867

Merged
merged 5 commits into from
Feb 23, 2023
Merged

infra: error on deprecation #1867

merged 5 commits into from
Feb 23, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 21, 2023 •
edited
Loading

Fixes #1866

Blocked by #1865 .

Thanks @Shinigami92 for your help.

@ST-DDT ST-DDT added s: on hold Blocked by something or frozen to avoid conflicts p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug c: infra Changes to our infrastructure or project setup labels Feb 21, 2023
@ST-DDT ST-DDT requested review from a team February 21, 2023 21:51
@ST-DDT ST-DDT self-assigned this Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #1867 (4e97a49) into next (aa3e771) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4e97a49 differs from pull request most recent head 6220230. Consider uploading reports for the commit 6220230 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #1867   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2355     2355           
  Lines      236433   236429    -4     
  Branches     1153     1156    +3     
=======================================
+ Hits       235558   235571   +13     
+ Misses        853      836   -17     
  Partials       22       22
Impacted Files Coverage Δ
src/modules/company/index.ts 100.00% <100.00%> (ø)
src/modules/image/index.ts 100.00% <100.00%> (ø)
src/modules/image/providers/lorempicsum.ts 91.71% <100.00%> (+0.05%) ⬆️
src/modules/image/providers/placeholder.ts 100.00% <100.00%> (ø)
src/modules/image/providers/unsplash.ts 100.00% <100.00%> (ø)
src/modules/git/index.ts 100.00% <0.00%> (ø)
src/modules/internet/user-agent.ts 94.08% <0.00%> (+5.02%) ⬆️

@ST-DDT ST-DDT removed the s: on hold Blocked by something or frozen to avoid conflicts label Feb 22, 2023
@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 22, 2023

Ready to review

Shinigami92
Shinigami92 reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run a pnpm run clean && pnpm install to regenerate a new lock file that also updates deep nested/shared dependencies

src/modules/company/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from Shinigami92 and a team February 22, 2023 19:05
@ST-DDT ST-DDT requested review from a team February 22, 2023 23:43
@ST-DDT ST-DDT enabled auto-merge (squash) February 23, 2023 22:57
@ST-DDT ST-DDT merged commit 11a5f51 into next Feb 23, 2023
@ST-DDT ST-DDT deleted the infra/error-on-deprecation branch February 24, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

Warn when using deprecated API
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox